Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selected options moved to hidden config #234

Merged
merged 15 commits into from
Nov 15, 2023
Merged

Conversation

landam
Copy link
Member

@landam landam commented Sep 30, 2023

  • printtimes

  • level

@landam landam marked this pull request as draft October 14, 2023 09:37
@landam landam added this to the Version 2.0 milestone Oct 14, 2023
@landam landam self-assigned this Oct 14, 2023
@landam landam requested a review from jerabekjak October 14, 2023 10:11
@landam landam marked this pull request as ready for review October 14, 2023 10:12
Copy link
Member

@jerabekjak jerabekjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options in .config work fine. THanks and sorry for the late review.

However, if
./bin/start-smoderp2d.py --config tests/config_files/quicktest_stream_rill.ini
the output file tests/data/output/control_point/point003.csv is in stream as it should be and the header is like this:

==> tests/data/output/control_point/point003.csv <==
# Hydrograph at the point with coordinates: 1.3453 0.8065
# A pixel size is [m2]: 0.25
time[s];deltaTime[s];rainfall[m];waterlevel[m];vRunoff[m3];q[m3/s];vFromField[m3];vRestsInStream[m3]
3.0000e+01;3.0000e+01;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00

But, if
./bin/start-smoderp2d.py --config tests/config_files/quicktest_sheet_stream.ini
the output file tests/data/output/control_point/point003.csv shows values like its not in a stream. And the header is:

==> tests/data/output/control_point/point003.csv <==
# Hydrograph at the point with coordinates: 1.3453 0.8065
# A pixel size is [m2]: 0.25
time[s];deltaTime[s];rainfall[m];waterLevel[m];sheetFlow[m3/s];sheetVRunoff[m3];sheetFlowVelocity[m/s];sheetVRest[m3];infiltration[m];surfaceRetetion[m];state;vInflow[m3];wLevelTotal[m];surfaceBil[m3];vToRill[m3];ratio;courant;courantRill;iter
3.0000e+01;3.0000e+01;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;1.0000e+00;1.9500e+00;1.9500e+00;0.0000e+00

But it should be like in the previous example since both quicktest_sheet_stream.ini and quickest_stream_rill.ini should have the stream in the point 003.

@jerabekjak
Copy link
Member

The options in .config work fine. THanks and sorry for the late review.

However, if ./bin/start-smoderp2d.py --config tests/config_files/quicktest_stream_rill.ini the output file tests/data/output/control_point/point003.csv is in stream as it should be and the header is like this:

==> tests/data/output/control_point/point003.csv <==
# Hydrograph at the point with coordinates: 1.3453 0.8065
# A pixel size is [m2]: 0.25
time[s];deltaTime[s];rainfall[m];waterlevel[m];vRunoff[m3];q[m3/s];vFromField[m3];vRestsInStream[m3]
3.0000e+01;3.0000e+01;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00

But, if ./bin/start-smoderp2d.py --config tests/config_files/quicktest_sheet_stream.ini the output file tests/data/output/control_point/point003.csv shows values like its not in a stream. And the header is:

==> tests/data/output/control_point/point003.csv <==
# Hydrograph at the point with coordinates: 1.3453 0.8065
# A pixel size is [m2]: 0.25
time[s];deltaTime[s];rainfall[m];waterLevel[m];sheetFlow[m3/s];sheetVRunoff[m3];sheetFlowVelocity[m/s];sheetVRest[m3];infiltration[m];surfaceRetetion[m];state;vInflow[m3];wLevelTotal[m];surfaceBil[m3];vToRill[m3];ratio;courant;courantRill;iter
3.0000e+01;3.0000e+01;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;0.0000e+00;1.0000e+00;1.9500e+00;1.9500e+00;0.0000e+00

But it should be like in the previous example since both quicktest_sheet_stream.ini and quickest_stream_rill.ini should have the stream in the point 003.

Just an update. The bug described above is also in master. Maybe this pull request can be merged to master since the options in hidden config work. ANd the bug described above can be solved separate branch(?).

@landam
Copy link
Member Author

landam commented Nov 15, 2023

@jerabekjak yes, please create new issue to describe this bug. It's seems to be unrelated to this PR.

@landam landam merged commit 958e465 into master Nov 15, 2023
19 checks passed
@landam landam deleted the params_to_hidden_config branch November 15, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants